This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
feat: switch to raw multihashes for blocks #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/mh-backed-datastore
branch
from
January 7, 2020 17:46
39b8fa8
to
3d42d0a
Compare
12 tasks
dirkmc
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Stebalien
added
the
status/blocked
Unable to be worked further until needs are met
label
Jan 7, 2020
Stebalien
force-pushed
the
feat/mh-backed-datastore
branch
2 times, most recently
from
January 7, 2020 18:23
ae9cdf4
to
e0992be
Compare
Stebalien
force-pushed
the
feat/mh-backed-datastore
branch
from
February 2, 2020 01:04
e0992be
to
72ee7bd
Compare
V0 CIDs are always "dag-pb". Using the "raw" codec indicates that these blocks are just raw data.
Stebalien
force-pushed
the
feat/mh-backed-datastore
branch
from
February 2, 2020 01:05
72ee7bd
to
8f266ca
Compare
The original changes in this PR were written by me and reviewed by @dirkmc. The new changes were written by @bonedaddy and reviewed by me. Hence, I'm calling this "ready". |
Woot thanks |
hsanjuan
removed
the
status/blocked
Unable to be worked further until needs are met
label
Feb 3, 2020
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…d-datastore feat: switch to raw multihashes for blocks This commit was moved from ipfs/go-ipfs-blockstore@451980b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: ipfs/kubo#6815