Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

add constructor that doesnt mess with datastore keys #83

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

whyrusleeping
Copy link
Member

No description provided.

@welcome
Copy link

welcome bot commented Aug 2, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@whyrusleeping
Copy link
Member Author

I kept getting when putting '"/blocks/CIQCBILJFHXDYSZJ5TQRRQ4SN3EH4AW4MF2CLK4O5QGU3QZX5LAAIEA"': key not supported by flatfs and couldnt figure out the right incantation to get it working.

In any case, this seems like a good thing to have.

@Stebalien Stebalien merged commit b57a17e into master Aug 3, 2021
@Stebalien Stebalien deleted the feat/no-prefix-constructor branch August 3, 2021 01:26
@Stebalien
Copy link
Member

Yep. The main issue is that flatfs doesn't encode keys (just restricts the keys). Ideally, we'd have a flatfs2 that actually handles key encoding.

@aschmahmann aschmahmann mentioned this pull request Dec 13, 2021
59 tasks
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
…x-constructor

add constructor that doesnt mess with datastore keys

This commit was moved from ipfs/go-ipfs-blockstore@b57a17e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants