This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Implement buzhash #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has the same properites as Rabin. Benchmark results: ``` name time/op Buzhash-4 14.3ms ± 7% Rabin-4 94.1ms ± 3% Default-4 1.74ms ± 7% name speed Buzhash-4 1.18GB/s ± 7% Rabin-4 178MB/s ± 3% Default-4 9.63GB/s ± 6% name alloc/op Buzhash-4 14.0kB ±48% Rabin-4 19.2MB ± 0% Default-4 474B ± 6% name allocs/op Buzhash-4 1.00 ± 0% Rabin-4 196 ±12% Default-4 2.00 ± 0% ``` License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Stebalien
suggested changes
Oct 6, 2019
|
|
||
| const ( | ||
| buzMin = 128 << 10 | ||
| buzMax = 512 << 10 |
There was a problem hiding this comment.
Can we configure these? Can we configure the expected/average chunk size?
There was a problem hiding this comment.
I will check what is the perf penalty for making these configurable.
There was a problem hiding this comment.
6%:
name old time/op new time/op delta
Buzhash-4 14.2ms ± 7% 15.1ms ± 6% +6.36% (p=0.000 n=20+19)
name old speed new speed delta
Buzhash-4 1.18GB/s ± 6% 1.11GB/s ±14% -6.64% (p=0.000 n=20+20)
Your call
There was a problem hiding this comment.
That's annoying. I'm fine leaving that off for now.
added 2 commits
October 6, 2019 13:53
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
|
By eliminating Reader interface and implementing buzhash chunking on a |
Don't return them either in benchmarks License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Stebalien
reviewed
Oct 7, 2019
buzhash.go
Outdated
| return nil, b.err | ||
| } | ||
|
|
||
| buf := b.buf |
There was a problem hiding this comment.
nit: buf is always b.buf. IMO, we should just use b.buf direct.y.
There was a problem hiding this comment.
That is a good nit, it didn't use to be like that.
Stebalien
approved these changes
Oct 7, 2019
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
added 3 commits
October 7, 2019 12:02
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai> License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
Implement buzhash This commit was moved from ipfs/go-ipfs-chunker@21b0c06
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has the same properites as Rabin.
Benchmark results:
License: MIT