Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand on the api error #138

Merged
merged 1 commit into from
Dec 27, 2018
Merged

expand on the api error #138

merged 1 commit into from
Dec 27, 2018

Conversation

schomatis
Copy link
Contributor

This would help the user figure out the problem described in ipfs/kubo#5784.

Fixes ipfs/kubo#5874.

@schomatis schomatis self-assigned this Dec 24, 2018
@schomatis schomatis requested a review from keks as a code owner December 24, 2018 01:15
@ghost ghost added the status/in-progress In progress label Dec 24, 2018
@schomatis schomatis mentioned this pull request Dec 24, 2018
Closed
magik6k
magik6k reviewed Dec 27, 2018
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword this slightly

http/client.go Outdated Show resolved Hide resolved
@schomatis
Copy link
Contributor Author

Fixed, thanks.

@schomatis
Copy link
Contributor Author

applied go fmt

@schomatis schomatis merged commit 55588cf into ipfs:master Dec 27, 2018
@ghost ghost removed the status/in-progress In progress label Dec 27, 2018
@schomatis schomatis deleted the fix/client/expand-on-api-error branch December 27, 2018 15:09
@Stebalien Stebalien mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@keks keks Awaiting requested review from keks

Assignees

@schomatis schomatis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schomatis @magik6k