feat:add strings option; re-implement file ignore #181
Conversation
There was a problem hiding this comment.
Thanks for taking this on @corntoole
I left a couple of comments. Could we also add some tests for file ignore?
|
Thanks for the review. I went with |
request.go
Outdated
| @@ -107,7 +107,7 @@ func (req *Request) convertOptions(root *Command) error { | |||
| } | |||
|
|
|||
| kind := reflect.TypeOf(v).Kind() | |||
| if kind != opt.Type() { | |||
There was a problem hiding this comment.
Can we add a comment here on why we don't need to convert string options?
There was a problem hiding this comment.
I reverted the change that excluded options with Type==Strings. I used an older PR as a starting point that had that exception, but I noticed that it would allow requests constructed with NewRequest(...) set non-array values. Would that comment still be necessary?
My understanding is that options with Type==String==reflect.String is not needed because v is already a string and does not need to be converted.
|
Ok, I've cut a release of go-ipfs-files. Could you squash, rebase, and update it ( |
- first step toward implementing file ignore feat(file-ignore): implement file ignore - add flags for providing a gitignore and/or list of files to ignore - construct a filter to be passed to a SerialFile feat(file-ignore): use go-ipfs-files fork; use renamed constructor feat(file-ignore): test case w. ignore rules; refactor parseArgs feat(file-ignore): ignore-rule opt is open-ended - make ignore-rules options accept a path to a file - add test case for ignore rules file feat(file-ignore): help-text for variardic opts - show StringsOption as variardic option in help-text - add test case for variardic option feat(file-ignore): rename rulesfile opt; fix typos feat(file-ignore): temp replace of go-ipfs-files - temporarily using go-ipfs-files fork until go-ipfs-files#26 is merged - trying to get ci/cd builds working - will revert before merging feat(file-ignore): refactor cli/parse.go#setOpts feat(file-ignore): cleanup parse.go; add test-case feat(file-ignore): update ignore option copytext feat(file-ignore): check opt against `optDef.Type` - revert exclusion of options with `Strings` type, so those option values are typechecked - add command test cases feat(file-ignore): add test-case w. hidden file feat(file-ignore): build against go-ipfs-files@latest feat(file-ignore): update go.mod/go.sum
corntoole
force-pushed
the
feat/add-strings-option
branch
from
56ed3c5 to
5fe469e
Compare
|
Ok, done. Thanks for the review |
|
Thanks for tackling this! |
This PR adds strings options type for passing in arrays of option values. The initial use-case for this feature is to pass multiple filepaths as options to IPFS file operations like add.
This PR also implements file-ignore by accepting a flag to use a local .gitignore file and/or an array of file paths to ignore similar to the example below:
$ tre 1 . 2 ├── another_dir 3 │ ├── a.png 4 │ └── b.png 5 └── another_other_dir 6 ├── bar_e.png 7 ├── bar_f.png 8 ├── bar_g.png 9 ├── c.png 10 ├── d.png 11 ├── foo_a.png 12 ├── foo_b.png 13 └── foo_c.png 14 15 2 directories, 10 files $ ipfs add -r --ignore "foo*.png" --ignore "bar*.png" another_other_dir/ added QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH another_other_dir/c.png added QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH another_other_dir/d.png added QmcLiRzrFw8SMTmN9umt2EJqzij8aCGGGVqcWAhZy7j2Sj another_other_dir 0 B / ? [-------------------------------------------------------------------------=]See ipfs#3643 and fission-suite/go-ipfs#2 for more context