Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update docs for interface changes #197

Merged
merged 1 commit into from
Apr 29, 2020
Merged

doc: update docs for interface changes #197

merged 1 commit into from
Apr 29, 2020

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien requested a review from hsanjuan April 29, 2020 15:59
hsanjuan
hsanjuan approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference between embedding io.Closer and not doing it.

@Stebalien
Copy link
Member Author

I only switched it because I've added the CloseWithError function.

@Stebalien Stebalien merged commit c3c51f7 into master Apr 29, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @hsanjuan