Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use NewSliceDirectory for duplicate file paths #220

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Sep 29, 2021

fixes ipfs/kubo#8264
alternative to #211

Being tested in ipfs/kubo#8493.

cli/parse.go Outdated Show resolved Hide resolved
@schomatis schomatis force-pushed the schomatis/fix/cli-parse-files branch from efe62f8 to 0e6ec5a Compare October 6, 2021 14:44
@schomatis schomatis changed the title fix(cli): resolve duplicate file paths as the URL case does fix(cli): use NewSliceDirectory for duplicate file paths Oct 6, 2021
@BigLep
Copy link

BigLep commented Nov 12, 2021

2021-11-12 conversation: needs review

@BigLep BigLep removed the request for review from Stebalien March 3, 2022 06:27
@BigLep
Copy link

BigLep commented Mar 3, 2022

@schomatis : how does this issue relate to ipfs/kubo#8493 ?

@schomatis
Copy link
Contributor Author

@BigLep Imported by it. The go-ipfs PR is basically a wrapper pointing to the changes in the dependency here where the actual logic was implemented.

@BigLep BigLep dismissed aschmahmann’s stale review March 23, 2022 17:13

Removing since @guseggert approved

@schomatis schomatis merged commit 606d9c3 into master Mar 23, 2022
@schomatis schomatis deleted the schomatis/fix/cli-parse-files branch March 23, 2022 17:13
@BigLep
Copy link

BigLep commented Mar 23, 2022

In case it wasn't clear, I removed the "requesting changes" from @aschmahmann because @guseggert had looked after and approved. It looks like that caused the PR to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CLI cannot process multiple passed files with the same name
4 participants