fix(cli): use NewSliceDirectory for duplicate file paths #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
previously requested changes
Oct 1, 2021
schomatis
force-pushed
the
schomatis/fix/cli-parse-files
branch
from
efe62f8
to
0e6ec5a
Compare
schomatis
changed the title
|
2021-11-12 conversation: needs review |
|
@schomatis : how does this issue relate to ipfs/kubo#8493 ? |
|
@BigLep Imported by it. The go-ipfs PR is basically a wrapper pointing to the changes in the dependency here where the actual logic was implemented. |
guseggert
approved these changes
Mar 22, 2022
|
In case it wasn't clear, I removed the "requesting changes" from @aschmahmann because @guseggert had looked after and approved. It looks like that caused the PR to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ipfs/kubo#8264
alternative to #211
Being tested in ipfs/kubo#8493.