-
Notifications
You must be signed in to change notification settings - Fork 44
improve AutoRelay configuration, add config option for static relays #154
Conversation
dfa28e0
to
a26f871
Compare
swarm.go
Outdated
// RelayService.* controls the "auto relay service" feature. | ||
// AutoRelay controls the "auto relay service" feature. | ||
// When enabled, the node will use relays if it is not publicly reachable. | ||
AutoRelay AutoRelay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am worried about ambiguity, better to be very clear around relay "service" and relay "client".
Would it be ok if we rename AutoRelay
to more explicit RelayClient
?
RelayClient RelayClient
This way, we will have RelaySevice
and RelayClient
sections that are easier to wrap the head around without reading docs.
@marten-seemann Y/n? (I'm happy to apply changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this. @vyzo, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 4cb1c6f
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@marten-seemann is this ready to merge, or do you plan on adding any other config related to the go-libp2p upgrade? @lidel is fine with how the config is setup and we'd like to do a release so we can unblock other things that rely on the various go-ipfs-config changes. If you have more changes to make that's fine, we'll have to partially revert #146 (i.e. the libp2p things, but not the OptionalInteger changes), release and then re-release later. |
This is ready to merge. I'm planning to add another option for hole punching tomorrow, but that's a different thing, so it should be a separate PR.
Not sure I understand. The changes in #146 are all correct, as far as I can tell, and needed by the go-libp2p update. |
No description provided.