This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat: switch to raw multihashes for blocks #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/mh-backed-datastore
branch
from
3c4a6d0
to
071cf26
Compare
12 tasks
Stebalien
added
the
status/blocked
Stebalien
force-pushed
the
feat/mh-backed-datastore
branch
from
071cf26
to
11890cc
Compare
hsanjuan
suggested changes
Jan 29, 2020
hsanjuan
reviewed
Jan 31, 2020
We are deprecating these functions as ipfs strives to store multihashes directly on the datastore, rather than CIDs. Thus multiple CIDs might map to the same multihash. Making this functions reflect that behaviour might cause silent breakage in users. We prefer loud breakage. Users using CidToDsKey(c) should move to MultihashToDsKey(c.Hash()). Users using DsKeyToCid() should move to DsKeyToCidV1Raw() or DsKeyToMultihash(). Note that datastore should handle migrations to replace existing CID-encoded keys with raw multihashes, or preserve DsKeyToCid() and CidToDsKey() in their own codebases.
Allow passing in whatever codec type the user wants
Stebalien
removed
the
status/blocked
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
…atastore feat: switch to raw multihashes for blocks This commit was moved from ipfs/go-ipfs-ds-help@4782beb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: ipfs/kubo#6815