Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

Not compatible with github.com/ipfs/kubo@v0.18.1 #167

Closed
kylos101 opened this issue Feb 3, 2023 · 2 comments · Fixed by #168
Closed

Not compatible with github.com/ipfs/kubo@v0.18.1 #167

kylos101 opened this issue Feb 3, 2023 · 2 comments · Fixed by #168
Assignees
Labels
dependencies Pull requests that update a dependency file P0 Critical: Tackled by core team ASAP

Comments

@kylos101
Copy link

kylos101 commented Feb 3, 2023

Description

Projects that depend on ipfs/kubo@v0.18.1 cannot use ipfs/go-ipfs-http-client@v0.4.0. If we try, we get errors like:

go build .
# github.com/libp2p/go-libp2p-core/network
../../../go/pkg/mod/github.com/libp2p/go-libp2p-core@v0.20.1/network/rcmgr.go:166:27: network.NullResourceManager (type) is not an expression

go mod why github.com/libp2p/go-libp2p-core/network
# github.com/libp2p/go-libp2p-core/network
github.com/ipfs/go-ipfs-http-client
github.com/libp2p/go-libp2p-core/network

ipfs/go-ipfs-http-client depends on:

github.com/ipfs/interface-go-ipfs-core v0.7.0

Which depends on:

github.com/libp2p/go-libp2p-core v0.8.6

But is archived and contains deprecated methods like:

https://github.com/libp2p/go-libp2p-core/blob/654214c1b3401c0363ef464ce9db7e1b04a7ef3f/network/rcmgr.go#L165-L166

Potential next steps?

  1. Refactor ipfs/interface-go-ipfs-core to depend on github.com/libp2p/go-libp2p@v0.24.2, and use its core package instead of github.com/libp2p/go-libp2p-core@v0.8.6
  2. Update ipfs/go-ipfs-http-client to use the new ipfs/interface-go-ipfs-core using github.com/libp2p/go-libp2p@v0.24.2

Anything else

I wanted to surface an issue to the community to get it's corresponding guidance. Let me know what you think? 🙏

@welcome
Copy link

welcome bot commented Feb 3, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Feb 6, 2023
@philwinder
Copy link

Commenting to subscribe to this issue. https://github.com/filecoin-project/bacalhau cannot upgrade kubo until this is fixed, because we also use this http client.

@Jorropo Jorropo added P0 Critical: Tackled by core team ASAP P1 High: Likely tackled by core team if no one steps up labels Feb 6, 2023
@Jorropo Jorropo self-assigned this Feb 6, 2023
@Jorropo Jorropo added dependencies Pull requests that update a dependency file and removed P1 High: Likely tackled by core team if no one steps up labels Feb 6, 2023
@Jorropo Jorropo moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Feb 6, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Feb 10, 2023
@Jorropo Jorropo changed the title Not compatible with github.com/ipfs/kube@v0.18.1 Not compatible with github.com/ipfs/kubo@v0.18.1 Feb 10, 2023
kylos101 added a commit to gitpod-io/gitpod that referenced this issue May 8, 2023
kylos101 added a commit to gitpod-io/gitpod that referenced this issue May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file P0 Critical: Tackled by core team ASAP
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants