Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forced redirects (no shadowing on IPFS) #4

Closed
2 tasks done
lidel opened this issue Aug 10, 2022 · 1 comment
Closed
2 tasks done

Remove forced redirects (no shadowing on IPFS) #4

lidel opened this issue Aug 10, 2022 · 1 comment
Assignees
@justindotpub

Comments

@lidel
Copy link
Member

lidel commented Aug 10, 2022 •
edited by justindotpub
Loading

ipfs/specs#290 states that we don't support forced redirects because _redirects is looked up only when requested content path is not present in the DAG.

@justincjohnson mind cleaning this up? 🙏

  • removing Forced and all its uses in code and README examples, so it is not confusing people who use this library and expect it to work
  • return human-readable error when a redirect is defined with ! (forced flag), explaining forced redirects (and "shadowing") are not supported by IPFS gateways
@justindotpub justindotpub mentioned this issue Aug 11, 2022
Merged
@justindotpub
Copy link
Collaborator

Addressed in #7. Added you as reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justindotpub justindotpub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @justindotpub