Remove forced redirects support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justindotpub
commented
Aug 11, 2022
justindotpub
commented
- Remove forced redirects support
- Return a human-readable error is someone attempts to use forced redirects
- Return a human-readable error is someone attempts to use forced redirects
|
Closes #4 |
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 75.86% 80.70% +4.83%
==========================================
Files 1 1
Lines 58 57 -1
==========================================
+ Hits 44 46 +2
+ Misses 9 7 -2
+ Partials 5 4 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2 tasks
justindotpub
commented
Aug 12, 2022
| force = true | ||
| s = strings.Replace(s, "!", "", -1) | ||
| // See https://docs.netlify.com/routing/redirects/rewrites-proxies/#shadowing | ||
| return -1, fmt.Errorf("forced redirects (or \"shadowing\") are not supported by IPFS gateways") |
There was a problem hiding this comment.
I avoided "aka" and thought "also known as" might be long for an error message. Including links seems bad and prone to needing updating. I think I personally would prefer just "forced redirects" but if "shadowing" helps people, great. 👍
|
In the interest of having everything ready for you to approve and merge, I'm going to go ahead and merge this so that I can get my latest changes in kubo pointing at this code. But let me know if you want anything changed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.