Added a Contribute file #1734
Added a Contribute file #1734
Conversation
|
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
RichardLitt
force-pushed
the
feature/contribute-md
branch
from
efe13e5 to
790ffa7
Compare
|
Fixed commit, GitCop should be good now. |
|
|
||
| Guidelines: | ||
|
|
||
| - see the [dev pseudo-roadmap](dev.md) |
There was a problem hiding this comment.
out of scope for now, but we should probably update that dev roadmap sometime
There was a problem hiding this comment.
Will do! Added to my list of things to take a look at.
|
LGTM |
| Guidelines: | ||
|
|
||
| - see the [dev pseudo-roadmap](dev.md) | ||
| - please adhere to the protocol described in [the main ipfs repo](https://github.com/ipfs/ipfs) and [paper](http://static.benet.ai/t/ipfs.pdf). |
There was a problem hiding this comment.
also specs: https://github.com/ipfs/specs (WIP)
License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
force-pushed
the
feature/contribute-md
branch
from
790ffa7 to
3501aff
Compare
| - ask questions or talk about things in [Issues](https://github.com/ipfs/go-ipfs/issues) or #ipfs on freenode. | ||
| - ensure you are able to contribute (no legal issues please-- we'll probably setup a CLA) | ||
| - run `go fmt` before pushing any code | ||
| - run `golint` and `go vet` too -- some things (like protobuf files) are expected to fail. |
There was a problem hiding this comment.
maybe we should move this stuff to a contribute-go.md in ipfs/community
There was a problem hiding this comment.
It's good to have a contribute.md in this repository so that the issue gets flagged. There should be one central point of truth for all go repos; are there more than this one go repo? If so, then yes. If not, then I'd say keep it here and move all of the non-relevant stuff to community.
Maybe we can make an automatic tool to add community to all of the contribute.mds. Probably not my best idea ever.
Is this the only repo with GitCop?
There was a problem hiding this comment.
are there more than this one go repo?
yeah, we have many go repos. i think we should have <lang>-contribute.md and put all lang specific things there, and yep, link to that from this file (so it gets a notcie on posting issues)
|
couple more edits o/ but other than that LGTM. thanks @RichardLitt |
|
Want me to open another PR? Only see the one suggestion. |
|
@RichardLitt no worries, maybe once the |
ghost
mentioned this pull request
This will alert the user to check the contributing guidelines before opening a PR if they never have before for this repo. It will also provide a place for us to easily mention what GitCop is doing.