Using GitCop #23
Comments
|
Hm, I think this page says max commit subject of 50 characters: https://github.com/ipfs/community/blob/master/contribution-guidelines.md |
|
Yeah we can decrease it to 50, but I think it will make too much noise for not much gain as 80 should still be readable for most people. It might only be better for people looking at commits from smartphones, as today terminals are usually much wider than 80 characters and web browsers on recent desktop or laptops also have no problem with 80 characters. |
|
ok 80 sounds good |
|
Maybe the gitcop message should mention the commit hook directly too |
|
@spikebike just had a hard time figuring out how to make this happen. maybe also have a couple of commands that guide people to amending their commits? (many people dont know how to use git rebase) |
|
@jbenet ok I will improve the GitCop message and https://github.com/ipfs/community/blob/master/docs/commit-message.md soon. |
This uses OC to export metrics via Prometheus. This also means that other OC metrics, such as the ones in go-libp2p-kad-dht can be exposed (via Prometheus, and whatever other exporters are used). I did some checks that no existing metrics move as a result.
License: MIT Signed-off-by: Eric Wu <myself659@163.com>
This series of commits aims to update go-ipfs to follow a dual-licensing best practice based on research into open-source licensing by @ianjdarrow. He recommends a dual MIT and Apache 2.0 license - > This has two major benefits: > - There are concerns in the open source community about whether the MIT license leaves users vulnerable to patent infringement claims. We think the pure legal risk is small, but the way the open source community interacts with our project is really important. It makes sense to pick the license that makes the largest number of people comfortable. - There's now no reason to adopt a separate DCO, since the Apache-2 license grant addresses the same issue. > Why use a dual license, instead of just Apache-2? The Apache-2 license is incompatible with the GPLv2 license, which includes things like the Linux kernel. With a dual license, GPLv2 projects can just use the MIT license instead. Our goal is to make our software available to as many projects as possible, so we'd rather adopt a licensing scheme that doesn't exclude anyone. In addition to these commits, we also need to get an explicit OK from current and past contributors to give their consent to relicensing - which will happen in an issue thread.
We want to use GitCop to make sure the commits have the following trailers:
We might also limit the subject of each commit to 80 characters.
What do you think?
The text was updated successfully, but these errors were encountered: