Wired up the trickle dag flag for the add command #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
dylanPowers
added
status/in-progress
License: MIT Signed-off-by: Dylan Powers <dylan.kyle.powers@gmail.com>
dylanPowers
force-pushed
the
use-trickle-dag
branch
from
dffecee
to
600e152
Compare
|
Added the signed-off-by lines |
|
this LGTM |
whyrusleeping
added a commit
that referenced
this pull request
Jun 17, 2015
Wired up the trickle dag flag for the add command
|
This needs a test case. We had this in there for weeks without knowing it didn't work... @whyrusleeping please don't merge things without tests |
|
I'm writing the test right now |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1368