swap transport over to spdystream #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something is wrong in the spdystream 'IsClosed' implementation. Right now, its only ever counted closed when we call Close on it, but the other muxers have an 'IsClosed' impl that will notice if the other side closes the stream. |
|
fixed here: jbenet/go-peerstream#10 |
whyrusleeping
force-pushed
the
feat/spdystream
branch
from
4031457
to
8bbde22
Compare
|
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
|
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
There was doublewrapping with an unneeded msgio. given that we use a stream muxer now, msgio is only needed by secureConn -- to signal the boundaries of an encrypted / mac-ed ciphertext. Side note: i think including the varint length in the clear is actually a bad idea that can be exploited by an attacker. it should be encrypted, too. (TODO) License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/spdystream
branch
from
741a897
to
7908e88
Compare
|
@jbenet i screwed up godeps... |
whyrusleeping
force-pushed
the
feat/spdystream
branch
from
7908e88
to
6703d83
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this. I'm pushing this up for @diasdavid to take a peek at, and for @jbenet to see if he knows why the p2p/test/reconnect tests are failing.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com