Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bitswap better #2798

Merged
merged 1 commit into from
Jun 11, 2016
Merged

Make bitswap better #2798

merged 1 commit into from
Jun 11, 2016

Conversation

whyrusleeping
Copy link
Member

Made a few changes to bitswap that significantly improve performance. By focusing on getting the cancel messages out to peers as fast as possible, and delaying sending blocks to peers we receive many cancels from we reduce the number of duplicate block receipts. I ran some tests on a network with 20ms latency between nodes (10ms per link) and have the results here: https://ipfs.io/ipfs/QmNyCqMQe1r3dQsAQEsncNqQGkF2YEyB5w6JRdNLRLDcox/smarter%20bitswap%20test%20info%20%2810ms%29.pdf

I can run more tests, but it takes a little while to do and these results are pretty good.

License: MIT
Signed-off-by: Jeromy why@ipfs.io

@whyrusleeping
Copy link
Member Author

thats really weird... somehow these changes make the tests in test/integration hang after the completed successfully. The defer'ed close calls seem to be getting stuck somewhere

@whyrusleeping
Copy link
Member Author

test data generated with: https://github.com/whyrusleeping/bitswap-test

@whyrusleeping whyrusleeping added the need/review Needs a review label Jun 3, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Jun 7, 2016

LGTM, the first commit is failing tests so it is best to squash it in.

@Kubuxu Kubuxu removed the need/review Needs a review label Jun 8, 2016
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@Kubuxu Kubuxu added the RFM label Jun 10, 2016
@whyrusleeping whyrusleeping merged commit c9ddc7d into master Jun 11, 2016
@whyrusleeping whyrusleeping deleted the feat/smarter-bitswap branch June 11, 2016 23:52
@jbenet
Copy link
Member

jbenet commented Aug 27, 2016

Would be great to have those tests runnable to create a graph locally, to test against master.

was it you @Kubuxu making some nice dup graphs? or maybe @ion1?

@Kubuxu
Copy link
Member

Kubuxu commented Aug 27, 2016

I don't think it was me.

@jbenet jbenet mentioned this pull request Aug 28, 2016
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants