Make bitswap better #2798
Merged
Make bitswap better #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thats really weird... somehow these changes make the tests in |
|
test data generated with: https://github.com/whyrusleeping/bitswap-test |
|
LGTM, the first commit is failing tests so it is best to squash it in. |
whyrusleeping
force-pushed
the
feat/smarter-bitswap
branch
from
1d0526e
to
970cc79
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
feat/smarter-bitswap
branch
from
970cc79
to
d16591a
Compare
Closed
|
I don't think it was me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few changes to bitswap that significantly improve performance. By focusing on getting the cancel messages out to peers as fast as possible, and delaying sending blocks to peers we receive many cancels from we reduce the number of duplicate block receipts. I ran some tests on a network with 20ms latency between nodes (10ms per link) and have the results here: https://ipfs.io/ipfs/QmNyCqMQe1r3dQsAQEsncNqQGkF2YEyB5w6JRdNLRLDcox/smarter%20bitswap%20test%20info%20%2810ms%29.pdf
I can run more tests, but it takes a little while to do and these results are pretty good.
License: MIT
Signed-off-by: Jeromy why@ipfs.io