-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrations to gx #2825
Migrations to gx #2825
Conversation
a99eb96
to
d64c1d1
Compare
483b512
to
ec7d976
Compare
LGTM |
Let me know when you want to merge |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
9a1a2a0
to
fb0aa63
Compare
@whyrusleeping it is good for merge now |
Hey this merge I think broke some stuff. Either that or I'm ignorant to how this works. Quite possible btw.
The only way I was able to remedy this was to install the goleveldb repo independently and remove those _workspace references in the imports. |
As you can see there is no goleveldb at all: https://github.com/ipfs/go-ipfs/tree/master/Godeps/_workspace/src/github.com/syndtr/ Make sure that you did good pull, no unchecked files and run Where do you have those files imported? |
This is coming from https://github.com/OpenBazaar/openbazaar-go |
@hoffmabc do you have some repro steps? I can definitely take a look at it. We're in the middle of transitioning all the rest of our deps from godeps into gx so that we can avoid problems like this in the future. |
Looks like openbazaar vendors go-ipfs in https://github.com/OpenBazaar/openbazaar-go/tree/master/vendor/github.com/ipfs/go-ipfs it is possible that something got stale or not removed or something. I've grep'ed go-ipfs codebase, there is no reference to old Godep'ed goleveldb anywhere. |
@cpacia could answer this better probably but there is a possibility of something lingering, but I completely cleaned my $GOPATH and started from scratch just doing
and this is what I got. I then proceeded to install go-ipfs and gx separately and still didn't improve. |
Ok, everything is explained now I think: https://github.com/OpenBazaar/openbazaar-go/blob/f62cbb590cb60bcce4f4dbe540f643c355385707/core/core.go OpenBazaar uses vendored deps of go-ipfs directly, that dep was removed from place where OB references it. |
Ok gotcha thanks |
That was my ide autochaning the import on me :p Also @hoffmabc we aren't working out of master. Just last releases. |
…-whatever Migrations to gx This commit was moved from ipfs/kubo@9cb55b0
Part of #2722