Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating away from Godeps #2722

Closed
Kubuxu opened this issue May 17, 2016 · 5 comments · Fixed by #5440
Closed

Migrating away from Godeps #2722

Kubuxu opened this issue May 17, 2016 · 5 comments · Fixed by #5440
Assignees
Labels
help wanted Seeking public contribution on this issue

Comments

@Kubuxu
Copy link
Member

Kubuxu commented May 17, 2016

Many packages in Godeps are our own (ipfs, whyrusleeping) so we should easily be able to push the to gx, others are external but we also can push them to gx.

Question is: do we want to do that, if yes what should be the time frame as it will be quite a bit of work. There are, as for today, 54 packages in Godeps.

@Kubuxu
Copy link
Member Author

Kubuxu commented May 18, 2016

Dependencies still inside Godpes:

Generated with:
jq '.Deps | .[].ImportPath' -r <Godeps/Godeps.json | sed 's/^/* [ ] /'

@kevina
Copy link
Contributor

kevina commented May 18, 2016

Note: Migrating github.com/ipfs/go-datastore will cause me some grief with pull request #2634.

@Kubuxu
Copy link
Member Author

Kubuxu commented May 18, 2016

github.com/ipfs/go-datastore has quite a lot of godeps and deps on its own so it will take a while.

@kalmi
Copy link
Contributor

kalmi commented Jun 20, 2016

gx install is now broken on Windows when ipfs's source's root is somewhat deeply nested. For example this is too deep: C:\Projects\Go\src\github.com\ipfs\go-ipfs

whyrusleeping/gx#80

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 19, 2016
@zramsay
Copy link
Contributor

zramsay commented Jun 8, 2017

Happy to pick this up (Godeps yuck). Started with PR ^

Stebalien added a commit that referenced this issue Sep 7, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 7, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Sep 7, 2018
@ghost ghost added the status/in-progress In progress label Sep 7, 2018
Stebalien added a commit that referenced this issue Sep 7, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 7, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 7, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 10, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 10, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 11, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 11, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 11, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 11, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Sep 11, 2018
fixes #2722

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost removed the status/in-progress In progress label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants