fix(ci): make go-ipfs-as-a-library work without external peers #8978
+66
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
changed the title
ajnavarro
changed the title
ajnavarro
changed the title
ajnavarro
requested review from
guseggert and
lidel
and removed request for
guseggert
lidel
changed the title
It was causing some build timeouts error because CircleCI was throttling WAN connections. It closes ipfs#8956 .
since this is example, this should make things easier to follow
lidel
force-pushed
the
fix/flacky-examples-test
branch
from
a78c731
to
13a77d6
Compare
lidel
approved these changes
May 25, 2022
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
* Do not connect to external nodes on ipfs as a lib example. It was causing some build timeouts error because CircleCI was throttling WAN connections. It closes #8956 * style: rename node vars since this is example, this should make things easier to follow Co-authored-by: Marcin Rataj <lidel@lidel.org>
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
* Do not connect to external nodes on ipfs as a lib example. It was causing some build timeouts error because CircleCI was throttling WAN connections. It closes #8956 * style: rename node vars since this is example, this should make things easier to follow Co-authored-by: Marcin Rataj <lidel@lidel.org> (cherry picked from commit e8f1ce0)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
* Do not connect to external nodes on ipfs as a lib example. It was causing some build timeouts error because CircleCI was throttling WAN connections. It closes #8956 * style: rename node vars since this is example, this should make things easier to follow Co-authored-by: Marcin Rataj <lidel@lidel.org> (cherry picked from commit e8f1ce0)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
* Do not connect to external nodes on ipfs as a lib example. It was causing some build timeouts error because CircleCI was throttling WAN connections. It closes #8956 * style: rename node vars since this is example, this should make things easier to follow Co-authored-by: Marcin Rataj <lidel@lidel.org> (cherry picked from commit e8f1ce0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was causing some build timeout errors because CircleCI was throttling
WAN connections.
It closes #8956 (was flaky test)