Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests sometimes are timing out when testing go-ipfs-as-a-library #8956

Closed
3 tasks done
ajnavarro opened this issue May 9, 2022 · 2 comments · Fixed by #8978
Closed
3 tasks done

Tests sometimes are timing out when testing go-ipfs-as-a-library #8956

ajnavarro opened this issue May 9, 2022 · 2 comments · Fixed by #8978
Assignees
@ajnavarro
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up topic/test failure Topic test failure
Milestone
Best Effort Track

Comments

@ajnavarro
Copy link
Member

Checklist

Installation method

built from source

Version

master branch

Config

No response

Description

Tests are timing out because Republisher never closes, it is always waiting for the current value to be published on Republisher.WaitPub
@ajnavarro ajnavarro added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels May 9, 2022
@ajnavarro ajnavarro mentioned this issue May 10, 2022
Closed
@ajnavarro
Copy link
Member Author

It took me some time to understand all the Makefiles and figure out that FUSE tests are not running on CI. The real problem is a flaky test executing go-ipfs-as-a-library, sometimes it just stops writing text to the terminal, and after 10 minutes, CircleCI stops it.

@ajnavarro ajnavarro changed the title Tests are timing out because of ipns_test.go Tests are timing out when testing go-ipfs-as-a-library May 10, 2022
@ajnavarro ajnavarro changed the title Tests are timing out when testing go-ipfs-as-a-library Tests sometimes are timing out when testing go-ipfs-as-a-library May 10, 2022
@lidel
Copy link
Member

lidel commented May 10, 2022 •
edited
Loading

To get more details, run test like this:

cd docs/examples/go-ipfs-as-a-library
go run main.go

You will see the test tries to fetch some CID from public IPFS and sometimes fails on CI (most likely because circleCI is throttling WAN connections due to abuse)

As discussed during stewards colo, we need to

  • refactor go-ipfs/docs/examples/go-ipfs-as-a-library/main_test.go so it does not fetch data from public swarm
    • need to spawn a local (additional) IPFS node instead, that provides data. that wayt test works in 'offline" mode (that way CI won't break the test if they throttle WAN data transfers).

@lidel lidel added topic/test failure Topic test failure kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed need/triage Needs initial labeling and prioritization labels May 10, 2022
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team May 10, 2022
@lidel lidel added this to the Best Effort Track milestone May 10, 2022
ajnavarro added a commit to ajnavarro/go-ipfs that referenced this issue May 16, 2022
@ajnavarro
Do not connect to external nodes on ipfs as a lib example.
6ec90d3 
It was causing some build timeouts error because CircleCI was throttling
WAN connections.

It closes ipfs#8956 .
@ajnavarro ajnavarro mentioned this issue May 16, 2022
Merged
@ajnavarro ajnavarro self-assigned this May 16, 2022
@ajnavarro ajnavarro moved this from 🥞 Todo to 🔎 In Review in IPFS Shipyard Team May 16, 2022
lidel pushed a commit to ajnavarro/go-ipfs that referenced this issue May 24, 2022
@ajnavarro @lidel
Do not connect to external nodes on ipfs as a lib example.
6dc4bc2 
It was causing some build timeouts error because CircleCI was throttling
WAN connections.

It closes ipfs#8956 .
Repository owner moved this from 🔎 In Review to 🎉 Done in IPFS Shipyard Team May 25, 2022
lidel added a commit that referenced this issue May 25, 2022
@ajnavarro @lidel
fix(ci): make go-ipfs-as-a-library work without external peers (#8978)
e8f1ce0 
* Do not connect to external nodes on ipfs as a lib example.

It was causing some build timeouts error because CircleCI
was throttling WAN connections.

It closes #8956

* style: rename node vars

since this is example, this should make things easier to follow

Co-authored-by: Marcin Rataj <lidel@lidel.org>
guseggert pushed a commit that referenced this issue Jun 8, 2022
@ajnavarro @lidel @guseggert
fix(ci): make go-ipfs-as-a-library work without external peers (#8978)
a4cc162 
* Do not connect to external nodes on ipfs as a lib example.

It was causing some build timeouts error because CircleCI
was throttling WAN connections.

It closes #8956

* style: rename node vars

since this is example, this should make things easier to follow

Co-authored-by: Marcin Rataj <lidel@lidel.org>
guseggert pushed a commit that referenced this issue Jun 8, 2022
@ajnavarro @guseggert
fix(ci): make go-ipfs-as-a-library work without external peers (#8978)
a4d1a8a 
* Do not connect to external nodes on ipfs as a lib example.

It was causing some build timeouts error because CircleCI
was throttling WAN connections.

It closes #8956

* style: rename node vars

since this is example, this should make things easier to follow

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit e8f1ce0)
guseggert pushed a commit that referenced this issue Jun 8, 2022
@ajnavarro @guseggert
fix(ci): make go-ipfs-as-a-library work without external peers (#8978)
bf06e54 
* Do not connect to external nodes on ipfs as a lib example.

It was causing some build timeouts error because CircleCI
was throttling WAN connections.

It closes #8956

* style: rename node vars

since this is example, this should make things easier to follow

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit e8f1ce0)
guseggert pushed a commit that referenced this issue Jun 8, 2022
@ajnavarro @guseggert
fix(ci): make go-ipfs-as-a-library work without external peers (#8978)
0fd9c53 
* Do not connect to external nodes on ipfs as a lib example.

It was causing some build timeouts error because CircleCI
was throttling WAN connections.

It closes #8956

* style: rename node vars

since this is example, this should make things easier to follow

Co-authored-by: Marcin Rataj <lidel@lidel.org>
(cherry picked from commit e8f1ce0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajnavarro ajnavarro

Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up topic/test failure Topic test failure
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging a pull request may close this issue.

fix(ci): make go-ipfs-as-a-library work without external peers ajnavarro/go-ipfs
2 participants
@lidel @ajnavarro