update merkeldag to use the explicit decoder registry #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
14 tasks
rvagg
approved these changes
May 31, 2023
|
@aschmahmann should i wait to merge this to stay in sync with the variant you're working on in boxo? |
|
Up to you. Might be easier in case we find any other oddities along the way. Sorry I'm the slow leg here, plan is to get the next round of everything bubbled up today for people to test with tomorrow. However, if you don't want things to exactly match anymore that's ok too. e.g. if boxo adds a setter for the registry and you don't want to. |
|
ending up with 2 variants of this code with slightly different semantics so that it's harder to migrate seems worse than keeping them in sync |
|
@aschmahmann - this should now include #105 and matches what's in boxo |
aschmahmann
reviewed
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the interface of
go-ipld-legacyto reflect the change in ipfs/go-ipld-legacy#12There is no breaking interface change in this update.
will wait until v0.2.0 of legacy is tagged and then use that version as the dependency here.
needs the equivalent update in the boxo fork of this repo i think.