This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Remove tiemout and refactor sizeBelowThreshold #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
force-pushed
the
schomatis/directory/unsharding-split/remove-timeout-refactor
branch
from
78c14df
to
10ac163
Compare
schomatis
force-pushed
the
schomatis/directory/unsharding-split/remove-timeout-refactor
branch
from
10ac163
to
e685e0a
Compare
schomatis
commented
Aug 6, 2021
schomatis
commented
Aug 9, 2021
aschmahmann
reviewed
Aug 12, 2021
aschmahmann
reviewed
Aug 12, 2021
aschmahmann
reviewed
Aug 25, 2021
Merged
schomatis
deleted the
schomatis/directory/unsharding-split/remove-timeout-refactor
branch
schomatis
added a commit
that referenced
this pull request
Oct 22, 2021
* fix(dir): remove timeout and evaluate switch *before* removing entry * BLOCKING: temporary fix * remove Shard cid not used and not maintained * update blocking readme * resolve FIXME * fix: add back concurrent option in dag.walk * decouple switch from directory downgrade
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from #100 (removing the internal timeout indeed simplified the
sizeBelowThresholdlogic significantly), but while refactoring this I uncovered an error in the logic: if we can't fetch enough shards to evaluate size against the threshold we error in the remove child but only after actually doing the remove. We now evaluate first and change state after.The patch is small but should be reviewed in detail as it touches the core switch logic.