This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix(hamt): catch panic in walkChildren #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2022-07-22 conversation: before we merge this code, we want to understand why we are even hitting this case to begin with. @ajnavarro is going to dig in here to help and will consult with @aschmahmann if necessary. |
|
Sounds good, un-assigning then. Ping me if I can be of help. |
|
@ajnavarro One more thought: I'd still advise landing this while delving deeper into the issue. It's not a proper fix but doesn't do additional harm either; worst case scenario you may catch the issue in the wild again with more information now from the log. |
|
Fixing a race condition here: #124 |
|
Moved to ipfs/boxo#393 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch panic from ipfs/kubo#9063. Both
linksandchildrenseem to have anilvalue at some position of the array (this is inconsistent per our own documentation and should never happen).I have no idea what's causing this. It could either have been introduced during sharding or just exposed by it. In any case unless this is recurrent I don't see much value in delving deeper, if anything we should be investing in cleaning HAMT internals first.
As a defensive refactoring I'm iterating
childreninstead oflinksas the existingeach()already does forwalkTrie, but this should be a no-op.