-
Notifications
You must be signed in to change notification settings - Fork 53
Update to use new Builder interface for creating CIDs. #7
Conversation
This is separated into two commits. The first does the minimal amount of change to support the fact that a Merkeldag has a cid.Builder and not a cid.Prefix. The second renames methods and such so the name is consistent. If the second is too much I can drop it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @schomatis may have opinions.
@schomatis for context, this patch allows us to pass around more complex cid "builders" instead of cid prefixes.
The key insight here is that cid.Prefix
is informational, it tells you about an existing CID. However, we tend to use it as a "config" or CID builder. This patch replaces those uses with an actual CID builder (introduced here: ipfs/go-cid#53).
(@Stebalien Thanks for including me and for the context.) This is a great change! I agree that the old @kevina I'm trying to build this PR but I'm having trouble finding |
@schomatis Fixed. Forgot to pin that. |
Thanks @kevina, this LGTM but I can't build against (For background, |
@schomatis thanks, I am not 100% following you, but I mostly agree. The way to get around this is to use In any case this is an API change so to build so it won't build anyway. I will update ipfs/kubo#5281 and id necessary split the automatic inline part into a separate P.R. to avoid blocking anything. |
Update to use new Builder interface for creating CIDs. This commit was moved from ipfs/go-unixfs@9900831
No description provided.