Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make UnixFSHAMTShard implement the ADL interface #11

Merged
merged 2 commits into from
Sep 27, 2021
Merged

make UnixFSHAMTShard implement the ADL interface #11

merged 2 commits into from
Sep 27, 2021

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Sep 27, 2021 •
edited
Loading

My understanding is that this is something we were supposed to implement. cc @hannahhoward @warpfork

hannahhoward
hannahhoward requested changes Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe I would add a check on the regular directory node as well.

@aschmahmann
Copy link
Contributor Author

@hannahhoward does it need to go on any of the other generated objects in here (e.g. Files)?

@aschmahmann aschmahmann merged commit c7f1fe6 into main Sep 27, 2021
@aschmahmann aschmahmann deleted the feat/implement-adl-interface branch September 27, 2021 21:32
@aschmahmann aschmahmann mentioned this pull request Sep 30, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschmahmann @willscott @hannahhoward