Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial file test #26

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Partial file test #26

merged 4 commits into from
Mar 9, 2022

Conversation

willscott
Copy link
Collaborator

No description provided.

@willscott willscott requested a review from mvdan March 3, 2022 18:08
@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Suggested version: v1.3.0
Comparing to: v1.2.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index f03e414..279ca3f 100644
--- a/go.mod
+++ b/go.mod
@@ -13,7 +13,7 @@ require (
 	github.com/ipfs/go-unixfs v0.3.1
 	github.com/ipld/go-car/v2 v2.1.1
 	github.com/ipld/go-codec-dagpb v1.3.0
-	github.com/ipld/go-ipld-prime v0.14.4
+	github.com/ipld/go-ipld-prime v0.14.5-0.20220303180638-1a0310848f49
 	github.com/multiformats/go-multicodec v0.3.1-0.20211210143421-a526f306ed2c
 	github.com/multiformats/go-multihash v0.1.0
 	github.com/spaolacci/murmur3 v1.1.0

gorelease says:

# github.com/ipfs/go-unixfsnode/data/builder
## incompatible changes
BuildUnixFSDirectory: changed from func([]*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, error) to func([]*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSDirectoryEntry: changed from func(string, int64, github.com/ipld/go-ipld-prime/datamodel.Link) (*github.com/ipld/go-codec-dagpb._PBLink, error) to func(string, int64, github.com/ipld/go-ipld-prime/datamodel.Link) (*github.com/ipld/go-codec-dagpb._PBLink, error)
BuildUnixFSFile: changed from func(io.Reader, string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error) to func(io.Reader, string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSRecursive: changed from func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error) to func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSShardedDirectory: changed from func(int, uint64, []*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, error) to func(int, uint64, []*github.com/ipld/go-codec-dagpb._PBLink, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
BuildUnixFSSymlink: changed from func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error) to func(string, *github.com/ipld/go-ipld-prime/linking.LinkSystem) (github.com/ipld/go-ipld-prime/datamodel.Link, uint64, error)
MapAssembler.AssembleEntry: changed from func(string) (github.com/ipld/go-ipld-prime/datamodel.NodeAssembler, error) to func(string) (github.com/ipld/go-ipld-prime/datamodel.NodeAssembler, error)
MapAssembler.Finish: changed from func() error to func() error
error: changed from interface{Error() string} to uint64

# github.com/ipfs/go-unixfsnode/file
## incompatible changes
LargeBytesNode.AsLargeBytes: added
Reader.Read, method set of StreamableByteNode: removed
StreamableByteNode: removed
## compatible changes
LargeBytesNode: added

# github.com/ipfs/go-unixfsnode/test
## compatible changes
package added

# summary
Cannot suggest a release version.
Incompatible changes were detected.

gocompat says:

(empty)

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by me

@willscott
Copy link
Collaborator Author

waiting for a tag of ipld-prime to base against

@hannahhoward hannahhoward merged commit 3629b1b into main Mar 9, 2022
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants