fix: update state to allow iter continuance on NotFound errors #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
added a commit
to ipld/go-car
that referenced
this pull request
Mar 8, 2023
allows non-path "full" extraction of a unixfs CAR that doesn't have complete data Ref: ipfs/go-unixfsnode#44
willscott
approved these changes
Mar 8, 2023
rvagg
added a commit
to ipld/go-car
that referenced
this pull request
Mar 13, 2023
allows non-path "full" extraction of a unixfs CAR that doesn't have complete data Ref: ipfs/go-unixfsnode#44
rvagg
added a commit
to ipld/go-car
that referenced
this pull request
Mar 14, 2023
allows non-path "full" extraction of a unixfs CAR that doesn't have complete data Ref: ipfs/go-unixfsnode#44
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 22, 2023
allows non-path "full" extraction of a unixfs CAR that doesn't have complete data Ref: ipfs/go-unixfsnode#44 This commit was moved from ipld/go-car@22c855b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from #42 and ipld/go-car#384, it was bugging me that I couldn't properly extract everything I could find in a partial unixfs CAR when it should be able to just skip over what's missing. It turns out that all that's needed is a bit of preemptive state updating on errors so that the user can decide whether to continue on
NotFounderrors—when they come back,Next()andDone()will have correct state.See test case for wikipedia test data with a big sharded directory with lots of missing branches—both subshards and leaves.