Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper tsize encoding in sharded files #65

Merged
merged 3 commits into from
Aug 25, 2023
Merged

fix: proper tsize encoding in sharded files #65

merged 3 commits into from
Aug 25, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 25, 2023

Extracted from #53, but fixed up to actually work properly - it turns out that passing on sz isn't quite right because of the need to care about the file byte sizes, so we need to track bot tsize and bytesizes.

Added some fixtures with reference CIDs so we can lock this behaviour down, references generated using Kubo; one of them was already in here (bafybeieyxejezqto5xwcxtvh5tskowwxrn3hmbk3hcgredji3g7abtnfkq) and it's unchanged, but expanded a little.

@rvagg rvagg requested a review from willscott August 25, 2023 04:23
data/builder/dir_test.go Outdated Show resolved Hide resolved
@rvagg rvagg merged commit e27c473 into main Aug 25, 2023
@rvagg rvagg deleted the rvagg/tsize branch August 25, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants