-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improvements & gateway-conformance support (light) #57
Conversation
1b7ee7d
to
8aa0368
Compare
8aa0368
to
4a95ee3
Compare
c2f45c8
to
3d2b3dc
Compare
3d2b3dc
to
db993fa
Compare
I don't think the gateway conformance test proxying works well with helia-http-gateway. something is up.. The test for url Is there a reason gateway-conformance is trying to use ipv6 addresses but reporting that it's trying to connect to Also, a lot of requests are requesting |
I confirmed that things are working much better running gateway-conformance directly with |
The report is currently too big for an upload, so I reduced the specs to just subdomain ipfs and ipns for now:
|
NOTE: all gateway-conformance tests are currently disabled
FYI: all gateway-conformance tests are disabled, but a lot of improvements are here that I want on the main branch. sorry folks. |
This certainly isn't done yet (and not just because we don't pass the conformance tests yet). For example, the environment variables to help enable subdomain gateway tests are not wired up yet. Wanted to see how close this approach was to working though.
Closes #30
Note: In addition to many tests failing, a number of them aren't showing up because some of the failures are killing the gateway-conformance tester due to this unresolved issue https://github.com/ipfs/gateway-conformance/blob/d855ec4fb9dac4a5aaecf3776037b005cc74c566/tooling/check/check.go#L358