Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create @helia/block-brokers package #341

Closed
Tracked by #289
SgtPooki opened this issue Dec 8, 2023 · 3 comments
Closed
Tracked by #289

feat: create @helia/block-brokers package #341

SgtPooki opened this issue Dec 8, 2023 · 3 comments
Assignees
@meandavejustice

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Dec 8, 2023 •
edited
Loading

Break out blockBrokers (at least trustless gateways) from helia so things like https://github.com/meandavejustice/trustless-gateway-fetch and #289 can consume it more easily.

For now, should be inside this main repo

some discussion held in slack at https://filecoinproject.slack.com/archives/C046HDAHA13/p1702058245269949
@SgtPooki SgtPooki mentioned this issue Dec 8, 2023
Closed
@meandavejustice
Copy link
Contributor

@SgtPooki Can you assign this to me?

@SgtPooki SgtPooki changed the title Break out blockBrokers (at least trustless gateways) from helia feat: create @helia/block-brokers package Dec 8, 2023
meandavejustice added a commit to meandavejustice/helia that referenced this issue Dec 8, 2023
@meandavejustice
feat: create @helia/block-brokers package (ipfs#341)
9007353 
- moves `packages/helia/src/block-brokers/` to `packages/block-brokers`
- adds necessary boilerplate files and config for `@helia/block-brokers` package
- updates all references to old block-brokers location in `package/helia` and top level config files
meandavejustice added a commit to meandavejustice/helia that referenced this issue Dec 8, 2023
@meandavejustice
feat: create @helia/block-brokers package (ipfs#341)
2f262f1 
- moves `packages/helia/src/block-brokers/` to `packages/block-brokers`
- adds necessary boilerplate files and config for `@helia/block-brokers` package
- updates all references to old block-brokers location in `package/helia` and top level config files
meandavejustice added a commit to meandavejustice/helia that referenced this issue Dec 8, 2023
@meandavejustice
feat: create @helia/block-brokers package (ipfs#341)
9f2bccc 
- moves `packages/helia/src/block-brokers/` to `packages/block-brokers`
- adds necessary boilerplate files and config for `@helia/block-brokers` package
- updates all references to old block-brokers location in `package/helia` and top level config files
@meandavejustice
Copy link
Contributor

Open questions here:

  • Do we need to still do browsers tests here?
  • default-hashers.ts is now used in multiple places. Its a small file, so probably fine to duplicate, but might make sense to pull into a @helia/utils package as things change.

achingbrain added a commit that referenced this issue Jan 8, 2024
@meandavejustice @SgtPooki @achingbrain
feat: create @helia/block-brokers package (#341) (#342)
cdcf553 
- moves `packages/helia/src/block-brokers/` to `packages/block-brokers`
- adds necessary boilerplate files and config for `@helia/block-brokers` package
- updates all references to old block-brokers location in `package/helia` and top level config files

---------

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain added a commit that referenced this issue Jan 8, 2024
@meandavejustice @SgtPooki @achingbrain
fix: create @helia/block-brokers package (#341) (#342)
2979147 
- moves `packages/helia/src/block-brokers/` to `packages/block-brokers`
- adds necessary boilerplate files and config for `@helia/block-brokers` package
- updates all references to old block-brokers location in `package/helia` and top level config files

---------

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Co-authored-by: Alex Potsides <alex@achingbrain.net>
This was referenced Jan 8, 2024
Closed
Merged
@SgtPooki
Copy link
Member Author

I believe this is done now

@SgtPooki SgtPooki mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meandavejustice meandavejustice

Labels
None yet
Projects
No open projects
Helia Working Group (inactive)
Status: 🏃‍♀️ In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SgtPooki @meandavejustice