fix: feat/initial-implementation #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds modules for a core library, a cli and an RPC client/server - Creates a `~/.helia` directory on startup - `helia daemon` starts a node with an RPC-over-libp2p server - `helia id` prints out node information online or offline
whizzzkid
commented
Feb 5, 2023
| @@ -15,8 +15,8 @@ | |||
| "ipfs" | |||
| ], | |||
| "engines": { | |||
| "node": ">=16.0.0", | |||
| "npm": ">=7.0.0" | |||
| "node": ">=18", | |||
There was a problem hiding this comment.
this is broken on 16:
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'semantic-release@20.1.0',
npm WARN EBADENGINE required: { node: '>=18' },
npm WARN EBADENGINE current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
achingbrain
requested changes
Feb 6, 2023
There was a problem hiding this comment.
Thanks for opening this but it's the wrong place to fix it.
This section is set by the aegir check-project command and the changes here will be overwritten the next time that command is run.
Instead please see this comment for a link to where to open a PR to ensure the value is correct even after aegir check-project is run again.
|
Thanks @achingbrain https://github.com/ipfs/aegir/pull/1184/files, once this is merged, I'll use this PR for the new aegir version. |
|
I'm going to close this PR as it only updates the node versions in the package.json files but is now full of conflicts because the PR it targeted has been squashed during the merge into main - it'll be simpler to open a new PR once ipfs/aegir#1184 is merged rather than try to fix the conflicts in this one. |
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
May 9, 2023
Refs: ipfs/helia#30 --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain
added a commit
that referenced
this pull request
Jan 8, 2024
* deps(dev): bump aegir from 39.0.13 to 40.0.11 Bumps [aegir](https://github.com/ipfs/aegir) from 39.0.13 to 40.0.11. - [Release notes](https://github.com/ipfs/aegir/releases) - [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md) - [Commits](ipfs/aegir@v39.0.13...v40.0.11) --- updated-dependencies: - dependency-name: aegir dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain
pushed a commit
that referenced
this pull request
Jan 8, 2024
## [@helia/car-v1.0.2](https://github.com/ipfs/helia-car/compare/@helia/car-v1.0.1...@helia/car-v1.0.2) (2023-08-27) ### Dependencies * **dev:** bump aegir from 39.0.13 to 40.0.11 ([#30](ipfs/helia-car#30)) ([ea26a0b](ipfs/helia-car@ea26a0b))
achingbrain
added a commit
that referenced
this pull request
Jan 8, 2024
Bumps [@helia/interface](https://github.com/ipfs/helia) from 1.2.2 to 2.0.0. - [Release notes](https://github.com/ipfs/helia/releases) - [Changelog](https://github.com/ipfs/helia/blob/main/CHANGELOG.md) - [Commits](https://github.com/ipfs/helia/compare/@helia/interface-v1.2.2...helia-v2.0.0) --- updated-dependencies: - dependency-name: "@helia/interface" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain
pushed a commit
that referenced
this pull request
Jan 8, 2024
## [@helia/dag-cbor-v1.0.2](https://github.com/ipfs/helia-dag-cbor/compare/@helia/dag-cbor-v1.0.1...@helia/dag-cbor-v1.0.2) (2023-08-27) ### Dependencies * bump @helia/interface from 1.2.2 to 2.0.0 ([#30](ipfs/helia-dag-cbor#30)) ([aa6ebcf](ipfs/helia-dag-cbor@aa6ebcf))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the node semver