fix!: replace dag walkers with generic CID extraction from blocks #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the codec-specific `.dagWalkers` property with a generic dag walker internally that uses the `Block` interface from the `multicodecs` module. - Removes the `.dagWalkers` property from the Helia interface - Adds `getCodec` and `getHasher` to retrieve codecs and hashers by code - Adds `loadCodec` and `loadHasher` options to allow sync or async loading of extra codecs/hashes in addition to staticlly configured ones in the `codecs`/`hashers` keys BREAKING CHANGE: the `.dagWalkers` property has been removed
|
I think the pinning benchmarks should be re-run with this PR before merging. The This could potentially be more expensive than deserializing a block, collecting |
SgtPooki
requested changes
Apr 3, 2024
achingbrain
force-pushed
the
fix/remove-dag-walkers
branch
from
9bb948d
to
c31f5e1
Compare
|
we need to run benchmarks to ensure no perf regression |
Updates all deps to the latest libp2p version. BREAKING CHANGE: helia now uses libp2p@2.x.x
achingbrain
force-pushed
the
fix/remove-dag-walkers
branch
from
da1386a
to
d071a30
Compare
An error occurred while trying to automatically change base from
deps/update-libp2p-2.x.x
to
main
September 15, 2024 11:08
|
Perf seems fine - the benchmark added by #633 shows comparable performance between this branch and main. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the codec-specific
.dagWalkersproperty with a generic dag walker internally that uses theBlockinterface from themulticodecsmodule..dagWalkersproperty from the Helia interfacegetCodecandgetHasherto retrieve codecs and hashers by codeloadCodecandloadHasheroptions to allow sync or async loading of extra codecs/hashes in addition to staticlly configured ones in thecodecs/hasherskeysBREAKING CHANGE: the
.dagWalkersproperty has been removedChange checklist