This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
feat: make the CoreAPI expose a streaming pin interface #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMure
commented
Nov 29, 2019
tests/block.go
Outdated
| if err != nil { | ||
| return | ||
| t.Skip(err) |
There was a problem hiding this comment.
This is problematic. Before this PR, the test was just terminating and didn't actually test anything.
With this workaround, running the test suite in go-ipfs produce block.go:230: failed to decode Protocol Buffers: incorrectly formatted merkledag node: unmarshal failed. proto: PBNode: wiretype end group for non-group.
I don't know what the root cause is.
This was referenced Nov 29, 2019
Merged
|
@MichaelMure that should fix your issue. Could you re-test? |
Stebalien
approved these changes
Dec 2, 2019
|
Originally this was blocked on releasing go-ipfs. However, I'm fine adding features to go-ipfs-http-client master and holding off on a release there until there's a go-ipfs release. |
Closed
|
@Stebalien can this be merged? |
|
Thanks for bumping this. |
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Dec 6, 2022
feat: make the CoreAPI expose a streaming pin interface This commit was moved from ipfs/interface-go-ipfs-core@292d906
guseggert
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
feat: make the CoreAPI expose a streaming pin interface This commit was moved from ipfs/interface-go-ipfs-core@292d906
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
feat: make the CoreAPI expose a streaming pin interface This commit was moved from ipfs/interface-go-ipfs-core@292d906
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #38
This PR expose a streamed
pin/lsAPI.