-
Notifications
You must be signed in to change notification settings - Fork 54
Add ID formatting functions, used by various IPFS cli commands #65
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd take a look at the key tests as well I suspect they also have plenty of id.Pretty()
being called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. It would be great if you could rebase the commits so we have:
- Dependency (+CI) updates
- Actual updates
I did that. One small issue: One of the go.mod commits also contained some code adding a fmt function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change but otherwise looks good (pending the other two PRs being ready to go)
4c54918
to
c998ba5
Compare
c998ba5
to
c604c5b
Compare
…efmt Add ID formatting functions, used by various IPFS cli commands This commit was moved from ipfs/interface-go-ipfs-core@b935dfe
…efmt Add ID formatting functions, used by various IPFS cli commands This commit was moved from ipfs/interface-go-ipfs-core@b935dfe
…efmt Add ID formatting functions, used by various IPFS cli commands This commit was moved from ipfs/interface-go-ipfs-core@b935dfe
For now, support "b36cid", "b58mh" ID formats.