Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Add ID formatting functions, used by various IPFS cli commands #65

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

petar
Copy link
Contributor

@petar petar commented Jul 16, 2020

For now, support "b36cid", "b58mh" ID formats.

@petar petar requested a review from aschmahmann July 16, 2020 21:25
@welcome
Copy link

welcome bot commented Jul 16, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@petar petar marked this pull request as ready for review July 20, 2020 21:53
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd take a look at the key tests as well I suspect they also have plenty of id.Pretty() being called.

idfmt.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. It would be great if you could rebase the commits so we have:

  • Dependency (+CI) updates
  • Actual updates

go.mod Outdated Show resolved Hide resolved
@petar
Copy link
Contributor Author

petar commented Jul 22, 2020

Looks pretty good to me. It would be great if you could rebase the commits so we have:

  • Dependency (+CI) updates
  • Actual updates

I did that. One small issue: One of the go.mod commits also contained some code adding a fmt function.
This code is still glued into the first squashed commit above.

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change but otherwise looks good (pending the other two PRs being ready to go)

go.mod Outdated Show resolved Hide resolved
tests/key.go Outdated Show resolved Hide resolved
@petar petar force-pushed the petar/namefmt branch 2 times, most recently from 4c54918 to c998ba5 Compare July 29, 2020 17:52
@aschmahmann aschmahmann merged commit b935dfe into master Jul 29, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
guseggert pushed a commit to ipfs/boxo that referenced this pull request Dec 6, 2022
…efmt

Add ID formatting functions, used by various IPFS cli commands

This commit was moved from ipfs/interface-go-ipfs-core@b935dfe
guseggert pushed a commit to ipfs/boxo that referenced this pull request Mar 15, 2023
…efmt

Add ID formatting functions, used by various IPFS cli commands

This commit was moved from ipfs/interface-go-ipfs-core@b935dfe
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
…efmt

Add ID formatting functions, used by various IPFS cli commands

This commit was moved from ipfs/interface-go-ipfs-core@b935dfe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants