Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Only call methods and access properties defined in the spec #2879

Closed
achingbrain opened this issue Jan 29, 2020 · 2 comments
Closed

Only call methods and access properties defined in the spec #2879

achingbrain opened this issue Jan 29, 2020 · 2 comments
Assignees
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature kind/resolved-in-helia

Comments

@achingbrain
Copy link
Member

The theory with the tests defined here is you can pass any instance of IPFS and they will ensure that the passed instance implements the spec fully.

To do that we should only invoke methods and access properties defined in the spec.

Currently the tests here assume that the passed instance has been created by ipfsd-ctl which adds extra properties and methods. The tests should be refactored to not do this and instead only use properties and methods defined in the spec.

@alanshaw
Copy link
Member

alanshaw commented Jan 30, 2020

There are also a bunch of tests that explicitly spawn go-ipfs nodes.

Screenshot 2020-01-30 at 11 05 58

Ideally js-ipfs would not have to install go-ipfs-dep, but the tests will fail if it does not. Removing type: 'go' is not really an option because browser nodes cannot connect to each other (no swarm addrs).

I think that we should either automatically skip the tests that require connections when there are no swarm addresses OR we make sure we spawn browser nodes with webrtc enabled so that they do have swarm addresses and they can connect to each other. I'm actually leaning towards the latter now!

@achingbrain achingbrain transferred this issue from ipfs-inactive/interface-js-ipfs-core Mar 10, 2020
@achingbrain achingbrain added exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature labels Mar 10, 2020
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@whizzzkid whizzzkid moved this from 🥞 Todo to 🛑 Blocked in js-ipfs deprecation May 24, 2023
@whizzzkid
Copy link

whizzzkid commented May 31, 2023

js-ipfs is being deprecated in favor of Helia. You can follow the migration plan here #4336 and read the migration guide.

This issue has been resolved in Helia! if this does not address your concern please let us know by reopening this issue before 2023-06-05!

@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in js-ipfs deprecation May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature kind/resolved-in-helia
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants