This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
chore: integrate libp2p new pubsub routing #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alanshaw
suggested changes
Aug 28, 2019
vasco-santos
force-pushed
the
chore/integrate-libp2p-new-pubsub-routing
branch
2 times, most recently
from
6ad700a
to
c92a241
Compare
vasco-santos
force-pushed
the
chore/integrate-libp2p-new-pubsub-routing
branch
from
c92a241
to
7375d8d
Compare
alanshaw
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On libp2p/js-libp2p#365, we decided to accept strings as the data being published. This usually was a barrier for entry users, so we just convert from string to buffer, if we receive a string.
Needs: