feat: integrate gossipsub by default #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
changed the title
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
2 times, most recently
from
3fc3adc
to
e753125
Compare
3 tasks
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
e753125
to
e238d43
Compare
jacobheun
reviewed
Jul 11, 2019
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
4edf353
to
4dd2e46
Compare
jacobheun
reviewed
Jul 11, 2019
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
913c809
to
34f663a
Compare
jacobheun
reviewed
Jul 12, 2019
jacobheun
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
9c48b1b
to
2b76101
Compare
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
3 times, most recently
from
1dd19c2
to
3790ca8
Compare
jacobheun
reviewed
Jul 24, 2019
src/index.js
Outdated
| if (this._config.EXPERIMENTAL.pubsub) { | ||
| this.pubsub = pubsub(this) | ||
| // start pubsub | ||
| if (this._config.pubsub.enabled) { |
There was a problem hiding this comment.
@vasco-santos what do you think about changing this logic a bit. I think if this._modules.pubsub is set, and this._config.pubsub.enabled !== false we should use pubsub. This would avoid people needing to add and enable it. We do this for discovery. If you've configured it, there's a really good chance you want to use it :)
There was a problem hiding this comment.
I agree, this is a better dev ex
This was referenced Jul 24, 2019
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
e45b1bb
to
c2cd663
Compare
vasco-santos
changed the title
BREAKING CHANGE: new configuration for deciding the implementation of pubsub to be used. In this context, the experimental flags were also removed.
vasco-santos
force-pushed
the
feat/integrate-gossipsub-by-default
branch
from
c5be8dd
to
65866b2
Compare
|
@jacobheun gossipsub was released 🎉 Just rebased and updated the PR |
jacobheun
approved these changes
Jul 31, 2019
|
0.26.0-rc.0 is out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: new configuration for deciding the implementation of pubsub to be used.
In this context, the experimental flags were also removed.
This PR modified the configuration of a libp2p node, in order to allow the selection of the pubsub implementation to use. Also Gossipsub was added as the default pubsub implementation in the tests
Needs:
gossipsub-jsUnblocks: