chore: review addressed

libp2p · Jul 11, 2019 · 913c809 · 913c809
1 parent 4dd2e46
commit 913c809
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/pubsub.js b/src/pubsub.js
@@ -56,12 +56,10 @@ module.exports = (node) => {
         return nextTick(callback, errCode(new Error(messages.NOT_STARTED_YET), codes.PUBSUB_NOT_STARTED))
       }
 
-      if (!Buffer.isBuffer(data) && typeof data !== 'string') {
-        return nextTick(callback, errCode(new Error('data must be a Buffer or a String'), 'ERR_DATA_IS_NOT_VALID'))
-      }
-
-      if (!Buffer.isBuffer(data)) {
+      try {
         data = Buffer.from(data)
+      } catch (err) {
+        return nextTick(callback, errCode(new Error('data must be convertible to a Buffer'), 'ERR_DATA_IS_NOT_VALID'))
       }
 
       pubsub.publish(topic, data, callback)