chore: disable broken circuit in js

this disables tests which fail due to JS being unable to use circuit v2
ipfs · Nov 18, 2021 · 27beb3b · 27beb3b
1 parent daadecc
commit 27beb3b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/test/circuit/all.js b/test/circuit/all.js
@@ -17,6 +17,7 @@ export default {
       ])
     }
   },
+  /* FIXME js needs circuit v2
   'js-go-go': {
     create: async (factory) => {
       const goRelayV2 = await createGoRelay([`${base}/ws`], factory)
@@ -27,20 +28,25 @@ export default {
       ])
     }
   },
+  */
+  /* FIXME js needs circuit v2
   'go-go-js': {
     create: (factory) => Promise.all([
       createGo([`${base}/ws`], factory),
       createGo([`${base}/ws`], factory),
       createJs([`${base}/ws`], factory)
     ])
   },
+  */
+  /* FIXME js needs circuit v2
   'js-go-js': {
     create: (factory) => Promise.all([
       createJs([`${base}/ws`], factory),
       createGo([`${base}/ws`], factory),
       createJs([`${base}/ws`], factory)
     ])
   },
+  */
   'go-js-go': {
     create: async (factory) => {
       const goRelayV2 = await createGoRelay([`${base}/ws`], factory)

diff --git a/test/circuit/browser.js b/test/circuit/browser.js
@@ -15,6 +15,7 @@ import {
 
 const base = '/ip4/127.0.0.1/tcp/0'
 
+// note: the order nodeA-nodeB-relay means "node A connect to B over relay"
 export default {
   'browser-go-js': {
     create: (factory) => Promise.all([
@@ -40,6 +41,7 @@ export default {
     ]),
     connect: connWithTimeout(1500)
   },
+  /* FIXME js needs circuit v2
   'browser-js-go': {
     create: (factory) => Promise.all([
       createProc([], factory),
@@ -48,6 +50,7 @@ export default {
     ]),
     connect: connWithTimeout(1500)
   },
+  */
   'js-go-browser': {
     create: (factory) => Promise.all([
       createJs([`${base}/ws`], factory),
@@ -112,6 +115,7 @@ export default {
     },
     skip: () => isWebWorker // no webrtc support in webworkers
   },
+  /* FIXME js needs circuit v2
   'browser-browser-go': {
     create: (factory) => Promise.all([
       createProc(['/ip4/127.0.0.1/tcp/24642/wss/p2p-webrtc-star'], factory),
@@ -128,6 +132,7 @@ export default {
     },
     skip: () => isWebWorker // no webrtc support in webworkers
   },
+  */
   'browser-browser-js': {
     create: (factory) => Promise.all([
       createProc(['/ip4/127.0.0.1/tcp/24642/wss/p2p-webrtc-star'], factory),

diff --git a/test/utils/circuit.js b/test/utils/circuit.js
@@ -15,7 +15,7 @@ export function createProc (addrs, factory) {
         Addresses: {
           Swarm: addrs
         },
-        relay: {
+        relay: { // FIXME: this is circuit v1, needs support of v2
           enabled: true,
           hop: {
             enabled: true
@@ -43,7 +43,7 @@ export function createJs (addrs, factory) {
         Addresses: {
           Swarm: addrs
         },
-        relay: {
+        relay: { // FIXME: this is circuit v1, needs support of v2
           enabled: true,
           hop: {
             enabled: true
@@ -68,6 +68,7 @@ export function createGo (addrs, factory, relay) {
           Swarm: addrs
         },
         Swarm: {
+          // go uses circuit v2
           RelayClient: {
             Enabled: true,
             StaticRelays
@@ -94,6 +95,7 @@ export function createGoRelay (addrs, factory) {
           Swarm: addrs
         },
         Swarm: {
+          // go uses circuit v2
           RelayClient: {
             Enabled: false
           },