This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
fix: multibase in pubsub http rpc interop tests #387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
2 times, most recently
from
a610dbb
to
b5c9d2c
Compare
lidel
changed the title
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
3 times, most recently
from
88fdb1c
to
f6575c4
Compare
17 tasks
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
10 times, most recently
from
e4660c9
to
ab7eb97
Compare
lidel
commented
Oct 22, 2021
lidel
added a commit
that referenced
this pull request
Oct 25, 2021
This temporarily disables pubsub tests as we are unable to test interop until both JS and GO changes land: - ipfs/kubo#8183 - ipfs/js-ipfs#3922 When we have that, we will re-enable skipped tests in #387
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
from
108bd99
to
ac5561b
Compare
achingbrain
reviewed
Nov 8, 2021
achingbrain
reviewed
Nov 8, 2021
4 tasks
achingbrain
reviewed
Nov 8, 2021
achingbrain
suggested changes
Nov 8, 2021
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
7 times, most recently
from
fd51402
to
450ecdd
Compare
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
from
450ecdd
to
18a5c7d
Compare
|
This extracts glue code that simplifies running interop against unreleased code of go-ipfs and js-ipfs packages from lerna monorepo. Makes it easier to demonstrate green CI and/or test end-to-end locally before submitting a PR.
the Rube Goldberg machine for testing HTTP RPC wire format changes end-to-end
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
from
18a5c7d
to
4064018
Compare
lidel
commented
Nov 29, 2021
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
from
79cb0d1
to
4b3e399
Compare
3 tasks
lidel
force-pushed
the
feat/pubsub-require-multibase
branch
from
4b3e399
to
81f4687
Compare
This ensures we run interop with official binary that is provided to regular users. It also removes the need for `go` binary when running in CI in js-ipfs repo.
|
Continued in #410 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
pubsubinterop tests with HTTP RPC wire format changes introduced in ipfs/js-ipfs#3922 and ipfs/kubo#8183 and runs against the code from mentioned PRs (js-ipfs from ipfs/js-ipfs#3922 + go-ipfs 0.11.0-rc1) to ensure things work end-to-end.TODO
\nto safeguard against regressions described in Pubsub subscription data encoding kubo#7939http-rpc-runtimeor refactor it to be useful outside of this PR. The Rube Goldberg machine for testing HTTP RPC wire format change end-to-endit should be removed after: