Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

test: JS IPFS 0.34 #51

Merged
merged 15 commits into from
Feb 13, 2019
Merged

test: JS IPFS 0.34 #51

merged 15 commits into from
Feb 13, 2019

Conversation

alanshaw
Copy link
Member

Merge of #48 and #46 for JS IPFS 0.34 release

@alanshaw
Copy link
Member Author

@jacobheun @vasco-santos the tests in exchange-files.js will consistently hang for about 1-2 minutes on one (or more) of the tests when run locally. e.g.

  exchange files
    ✓ connect go <-> js
    ✓ connect go <-> go2
    ✓ connect js <-> js2
    cat file
      ✓ go -> js: 1.02 kB (283ms)
      ✓ js -> go: 1.02 kB (184ms)
      ✓ js -> js2: 1.02 kB (451ms)
      ✓ go -> go2: 1.02 kB
      ✓ go -> js: 63.5 kB (249ms)
      ✓ js -> go: 63.5 kB (162ms)
      ✓ js -> js2: 63.5 kB (419ms)
      ✓ go -> go2: 63.5 kB
      ✓ go -> js: 65.5 kB (244ms)
      ✓ js -> go: 65.5 kB (152ms)
      ✓ js -> js2: 65.5 kB (57720ms)   <------- on this run it's this one, but it changes
      ✓ go -> go2: 65.5 kB
      ✓ go -> js: 524 kB (535ms)
      ✓ js -> go: 524 kB (418ms)
      ✓ js -> js2: 524 kB (842ms)
      ✓ go -> go2: 524 kB (40ms)

Removing the bootstrap nodes from the config (done here in this PR) helps but I still got an "FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory" on one of the runs I did.

There's clearly a bug(s) here and what I'm most concerned about is that libp2p doesn't seem to be stable connecting to just tens of nodes - when the DHT comes that number is going to increase significantly so this really needs to be addressed soon!

It would be rad if you could verify you're seeing the same hanging behaviour by checking out this PR and reverting the commit to remove the bootstrap nodes.

@alanshaw
Copy link
Member Author

Now blocked on "Error: No available transports to dial peer QmPBzrGKvhgpP6gGFU1fqmCE3CETzGZY4b5LzLhGwfDupc!" 😞

@jacobheun
Copy link
Contributor

And only on linux browsers, bleh. I'll take a look.

@daviddias
Copy link
Member

image

This is a great improvement since #44 (comment) \o/

@daviddias
Copy link
Member

what's the status ?

Alan Shaw and others added 12 commits February 13, 2019 08:45
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@daviddias
Copy link
Member

image

@daviddias
Copy link
Member

I took a moment to help drive this to the finish line and now CI is looking like:

image

Windows simply fails (probably missing some config??)

image

As for Firefox running, I re-run multiple times and the circuit tests are always the ones that crap out

https://travis-ci.com/ipfs/interop/jobs/177364408#L602-L607

@alanshaw
Copy link
Member Author

As for Firefox running, I re-run multiple times and the circuit tests are always the ones that crap out

We never ran tests on firefox before - it might actually be a bug! I found (and fixed) one yesterday thanks to testing in Firefox! ipfs-inactive/js-ipfs-http-client@f8ffa2b

@daviddias
Copy link
Member

@alanshaw interesting! That might mean that there also more bugs in js-ipfs to prune out. Shall we merge this PR as is so that we get the latest testing running and revisit with a new version of js-ipfs and js-ipfs-http-client?

@alanshaw
Copy link
Member Author

Yeah ok lets do it, this PR is 99% there. Lets fix up the other issues in another PR.

@daviddias daviddias merged commit 6058954 into master Feb 13, 2019
@daviddias daviddias deleted the test/0.34 branch February 13, 2019 09:53
@ghost ghost removed the status/in-progress In progress label Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants