Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find peer when there are no maddrs #62

Merged
merged 1 commit into from
Sep 3, 2024
Merged

feat: find peer when there are no maddrs #62

merged 1 commit into from
Sep 3, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Sep 3, 2024

What's in this PR

  • This aims to increase the providers that the check will actually check (and reduce the results with no addresses)
  • Explicitly look up peer maddrs with DHT FindPeer call when none are returned from the FindProviders call

Why?

Anecdotally, this case is pretty common (providers without maddrs that can be resolved independently with FindPeer)

@2color 2color merged commit c65b429 into main Sep 3, 2024
11 checks passed
@2color 2color deleted the add-find-peer branch September 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant