Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about mixed content issues when changing the gateway #648

Closed
da2x opened this issue Dec 27, 2018 · 0 comments
Closed

Warn about mixed content issues when changing the gateway #648

da2x opened this issue Dec 27, 2018 · 0 comments
Assignees
@lidel
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@da2x
Copy link

da2x commented Dec 27, 2018 •
edited
Loading

The options UI should display a warning about content being blocked because of mixed-content protections when the “Custom Local Gateway” option doesn't match the pattern https://.*/|http://127\.\d+\.\d+\.\d+:\d+/ (any HTTPS origin, or any origin on the loopback interface). This only needs to be visible when the pattern doesn't match.

Mockup: /ipfs/QmezHbfHAg7NyzrbqgeRpvJJPx5h7eikHb77HLBwkm5jps

Configurations like #19/#328/#604 and #645 all indicate that such a warning would be useful.

My own blog loads over HTTPS with images being loaded over IPFS. Someone contacted me to complain that images weren't loading, and after some troubleshooting we found out he had his IPFS Companion extension pointed at another IP address on his local network; which resulted in the same type of mixed content issues as other users have reported.
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature UX labels Jan 2, 2019
lidel added a commit that referenced this issue Jan 2, 2019
@lidel
feat: warn about mixed content issues
0c9797c 
Closes #648
@lidel lidel mentioned this issue Jan 2, 2019
Merged
@ghost ghost assigned lidel Jan 2, 2019
@ghost ghost added the status/in-progress In progress label Jan 2, 2019
@lidel lidel closed this as completed in #650 Jan 7, 2019
lidel added a commit that referenced this issue Jan 7, 2019
@lidel
feat: warning about mixed content issues (#650)
d59416d 
* feat: warn about mixed content issues

Closes #648
@ghost ghost removed the status/in-progress In progress label Jan 7, 2019
@lidel lidel mentioned this issue Jan 19, 2023
Closed
@github-actions github-actions bot mentioned this issue Feb 16, 2023
Closed
@github-actions github-actions bot mentioned this issue Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release ipfs-companion 2.23.0 ipfs/ipfs-companion
2 participants
@lidel @da2x