Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave request throttling blocks action button update #774

Closed
lidel opened this issue Oct 1, 2019 · 1 comment
Closed

Brave request throttling blocks action button update #774

lidel opened this issue Oct 1, 2019 · 1 comment
Assignees
Labels
area/brave Issues related to Brave Browser kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Oct 1, 2019

Finally, found out what is the cause of random browser action freezes! 🥶

It seems there is a limit of concurrent requests made by an extension, and it includes URLs for assets shipped with extension itself, such as icons.

This creates environment for unfortunate edge case: when we load a page with a lot of new assets that trigger delegated dht calls, internal request for "loading" browser action icon is marked as "pending":

pending-request-blocking-browser-action-menu-2019-10-01--11-57-51

Potential solutions:

  • (assuming its specific to browser action update) change the logic responsible for updating browser action, ensure icon update is async OR remove peer count and update the icon only when changing state between online ←→ offline.
  • revisit delegated routing modules, ensure every http call has an explicit timeout, make it configurable
@lidel lidel added kind/bug A bug in existing code (including security flaws) area/brave Issues related to Brave Browser labels Oct 1, 2019
@lidel lidel self-assigned this Oct 1, 2019
@lidel
Copy link
Member Author

lidel commented Jan 20, 2021

#967 (comment)

@lidel lidel closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/brave Issues related to Brave Browser kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

1 participant