Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chrome.sockets experiment #967

Closed
lidel opened this issue Jan 20, 2021 · 0 comments · Fixed by #985
Closed

Remove chrome.sockets experiment #967

lidel opened this issue Jan 20, 2021 · 0 comments · Fixed by #985
Assignees
@lidel
Labels
area/brave Issues related to Brave Browser effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Jan 20, 2021 •
edited
Loading

We already deprecated this experiment in recent release.
This issue is a reminder to remove embedded:chromesockets node type and migrate users to native node.
Hopefully, it will enable us to simplify the build and remove a lot of unused polyfills.

Context: Brave 1.19 shipped with native support for IPFS which leverages go-ipfs instead:
@lidel lidel added kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up area/brave Issues related to Brave Browser effort/days Estimated to take multiple days, but less than a week labels Jan 20, 2021
@lidel lidel self-assigned this Jan 20, 2021
This was referenced Jan 20, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@lidel lidel pinned this issue Jan 20, 2021
@lidel lidel mentioned this issue Mar 10, 2021
Merged
@lidel lidel unpinned this issue May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/brave Issues related to Brave Browser effort/days Estimated to take multiple days, but less than a week kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove embedded:chromesockets experiment ipfs/ipfs-companion
1 participant
@lidel