Mv3 review pr [do not merge] ⚠️ #1078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds mv3/ directory - setup fast builds with esbuild - setup prettier for formatting - setup eslint - setup typescript - adds BASIC handling of ipfs.io & dweb.link URLs to local node via declarativeNetRequest api (manifest v3) - adds BASIC handling of DNSLink requests by parsing, talking to local node via ipfs-http-client, and adding rule to declarativeNetRequest ruleset - adds boilerplate for popup
- adds mv3/ directory - setup fast builds with esbuild - setup prettier for formatting - setup eslint - setup typescript - adds BASIC handling of ipfs.io & dweb.link URLs to local node via declarativeNetRequest api (manifest v3) - adds BASIC handling of DNSLink requests by parsing, talking to local node via ipfs-http-client, and adding rule to declarativeNetRequest ruleset - adds boilerplate for popup
- add welcome page - add options page - add clipboard functionality - add status updates to popup - add basic UI styling to popup
- on installed checks - on uninstalled checks - runtime checks - options/state cleanup - add firefox request handling for when they support mv3
id expects and integer
meandavejustice
commented
Nov 15, 2022
| return state; | ||
| } | ||
|
|
||
| browser.runtime.onConnect.addListener((port: Runtime.Port) => { |
There was a problem hiding this comment.
⭐ MV3 Specific ⭐ This needs to be added for service_workers to stay alive.
meandavejustice
commented
Nov 15, 2022
| } | ||
| }); | ||
|
|
||
| // firefox specific requests |
There was a problem hiding this comment.
⭐ MV3 Specific ⭐
meandavejustice
commented
Nov 15, 2022
| const log = debug("ipfs-companion:request"); | ||
| log.error = debug("ipfs-companion:request:error"); | ||
|
|
||
| export default function createRequestModifier(getState, runtime) { |
There was a problem hiding this comment.
⭐ MV3 Specific ⭐ This is how we are creating the request from chrome to local node
|
After chatting with @whizzzkid, were going to go add mv3 version in a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is just so @lidel can do a review of the current state of the
mv3branch.The current feature set was chosen in order to prove what functionality is possible with mv3 in chrome. It is by no means complete. We have a good baseline for the future.
Features:
There is a quite a lot of unavoidable boilerplate in this pr, the main action happens in the following files: