feat(mv3): Config Migration #1228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
SgtPooki
requested changes
Jul 25, 2023
Comment on lines
+36
to
+38
| browser.runtime.onMessage.addListener((message) => { | ||
| if (message.type === 'ipfs-companion-migrate') { | ||
| browser.runtime.onMessage.removeListener(this) |
There was a problem hiding this comment.
is browser.runtime.onMessage.removeListener(this) supposed to be removing the anon/lambda function listener? this won't be the function. Change to non-anonymous function if that's the intention
| @@ -28,9 +28,23 @@ export async function runPendingOnInstallTasks () { | |||
| url: welcomePage | |||
| }) | |||
| case 'onVersionUpdate': | |||
| if (!displayReleaseNotes) return | |||
| // temporary disabled due to upgrade to MV3. | |||
There was a problem hiding this comment.
Do we want to double check the version to ensure mv3 update is what's needed?
|
Closing this as not longer needed, the required config is already in the right place, the only config that's weird is debug and countly, which has to be hard coded in worker context anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1226