-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds popup header and adds browserify-css and tachyons #319
Conversation
@@ -0,0 +1,172 @@ | |||
/*! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No module available for mdc.switch.css
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@material/switch
- but it only allows you to override the "on" state:
It is not currently possible to customize the color of a disabled or off (unchecked) switch
https://www.npmjs.com/package/@material/switch#sass-mixins
Our "off" state is the same as our "on" state (visually), we're not so much on/off as left/right so I needed to edit the CSS a little to achieve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it! |
If anyone wants to smoke-test refreshed GUI under Firefox, there is a new beta in Development channel: In my case it works well, even with |
@richardschneider I am afraid we switched min. version to Firefox 57, I see it is possible to set different range for desktop and mobile, Try again 🙂 |
The issue you are experiencing is not related to ipfs-companion, I think. I am using the beta with If the problem persists, report it at https://github.com/ipfs/webui/issues |
This is the popup UI component, as per the mockups. It's possible for this PR to be merged and released as is.
This adds a header to the popup displaying the IPFS icon (online/offline):
This also add the HTML code and CSS for the proposed embedded/external toggle but the component is currently
display: none
. It'll become visible when JS IPFS is added to the project.I've added
browserify-css
to allow us to require CSS files and addedtachyons
to give us consistent spacing, font sizes and ways of composing styles for components without bloating CSS (and is also consistent with other IPFS sites https://peerpad.net https://ipld.io). I've actually been able to remove all the styles in the browser action popup as they can all be expressed using tachyons atoms.